Skip to content

Conversation

j-bowhay
Copy link
Member

Towards #21833

Copy link
Contributor

@mdhaber mdhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks great - minimal, and looks correct. As a checklist for these very standard ones:

  • Applies the _transition_to_rng decorator
    • Passes correct old_name (``"seed"`, in this case) to decorator factory
    • Passes correct position_num (2, in this case) to decorator factory
  • replaces old keyword in signature with rng
  • replaces documentation of old keyword with final documentation recommended by SPEC 7
  • replaces most uses of old keyword in tests / other functions with rng / Generator
  • notes remaining uses of old keyword (left to test backward compatibility during transition)
  • check that decorate has replaced documentation correctly

If the tests come back happy and docs look good, I'll merge.

@mdhaber mdhaber mentioned this pull request Nov 13, 2024
50 tasks
@mdhaber
Copy link
Contributor

mdhaber commented Nov 13, 2024

CI is just falling apart but everything looks unrelated. Docs look good.

image

@mdhaber mdhaber merged commit f585942 into scipy:main Nov 13, 2024
31 of 38 checks passed
@mdhaber mdhaber added needs-release-note a maintainer should add a release note written by a reviewer/author to the wiki maintenance Items related to regular maintenance tasks labels Nov 13, 2024
@j-bowhay j-bowhay added this to the 1.15.0 milestone Nov 13, 2024
@lucascolley lucascolley changed the title API: linalg.clarkson_woodruff_transform: transition to rng (SPEC7) API: linalg.clarkson_woodruff_transform: transition to rng (SPEC7) Nov 13, 2024
@mdhaber mdhaber removed the needs-release-note a maintainer should add a release note written by a reviewer/author to the wiki label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.linalg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants