Skip to content

MAINT: interpolate: rename interpnd -> _interpnd #21754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

MAINT: interpolate: rename interpnd -> _interpnd #21754

merged 1 commit into from
Oct 25, 2024

Conversation

ev-br
Copy link
Member

@ev-br ev-br commented Oct 25, 2024

Reference issue

closes #19907

What does this implement/fix?

Add a leading undescore to the interpolate/_interpnd.so extension module.

Additional information

This is the last non-underscored private module in scipy/interpolate (dfitpack was done in #20612)

@ev-br ev-br added scipy.interpolate maintenance Items related to regular maintenance tasks labels Oct 25, 2024
@ev-br ev-br requested a review from h-vetinari October 25, 2024 11:20
@github-actions github-actions bot added Cython Issues with the internal Cython code base Meson Items related to the introduction of Meson as the new build system for SciPy labels Oct 25, 2024
@ev-br ev-br mentioned this pull request Oct 25, 2024
Closed
@ev-br ev-br force-pushed the interpnd_underscore branch from 8c7af6d to 0374b9c Compare October 25, 2024 11:40
j-bowhay
j-bowhay reviewed Oct 25, 2024
View reviewed changes
ev-br
ev-br commented Oct 25, 2024
View reviewed changes
@lucascolley lucascolley changed the title MAINT: interpolate: rename interpnd -> _interpnd MAINT: interpolate: rename interpnd -> _interpnd Oct 25, 2024
j-bowhay
j-bowhay reviewed Oct 25, 2024
View reviewed changes
@ev-br
MAINT: interpolate: rename interpnd -> _interpnd
2b3fec0 
Also add an import shim with the deprecation message.
@ev-br ev-br force-pushed the interpnd_underscore branch from 8f7cf55 to 2b3fec0 Compare October 25, 2024 20:30
j-bowhay
j-bowhay approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@j-bowhay j-bowhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting out this loose end!

@j-bowhay j-bowhay added this to the 1.15.0 milestone Oct 25, 2024
@j-bowhay j-bowhay merged commit af11139 into scipy:main Oct 25, 2024
39 checks passed
@h-vetinari h-vetinari mentioned this pull request Oct 25, 2024
Open
32 tasks
This was referenced Dec 22, 2024
Merged
Merged
@asi1024 asi1024 mentioned this pull request Jan 10, 2025
Open
8 tasks
jcannon-gplates added a commit to GPlates/gplately that referenced this pull request Jan 13, 2025
@jcannon-gplates
SciPy 1.15 renamed interpnd to _interpnd.
d47793a 
See scipy/scipy#21754

Fixes:
ImportError: cannot import name '_ndim_coords_from_arrays' from
'scipy.interpolate.interpnd'
@jcannon-gplates jcannon-gplates mentioned this pull request Jan 13, 2025
Merged
@PicoCentauri PicoCentauri mentioned this pull request Jan 28, 2025
Closed
@j-bowhay j-bowhay mentioned this pull request May 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-bowhay j-bowhay j-bowhay approved these changes

@h-vetinari h-vetinari Awaiting requested review from h-vetinari

Assignees
No one assigned
Labels
Cython Issues with the internal Cython code base maintenance Items related to regular maintenance tasks Meson Items related to the introduction of Meson as the new build system for SciPy scipy.interpolate
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

DEP: extend deprecation of private namespaces also to fortran-generated modules
2 participants
@ev-br @j-bowhay