DEP: signal: deprecate object arrays in sosfilt #21706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to scipygh-21211: we deprecated object arrays as inputs to `lfilter`, but forgot or did not know about `sosfilt`. These two should probably be in sync, hence follow the lfilter deprecation in sosfilt.
| @@ -3565,6 +3565,13 @@ def test_sosfilt_zi(self, dt): | |||
| _, zf = sosfilt(sos, np.ones(40, dt), zi=zi.tolist()) | |||
| assert_allclose_cast(zf, zi, rtol=1e-13) | |||
|
|
|||
| def test_dtype_deprecation(self, dt): | |||
There was a problem hiding this comment.
An obvious annoyance is that this test runs 4 times for each dt value, but doesn't consume dt.
Not sure if that meets the threshold to remove it from the parametrized class abstraction or not.
There was a problem hiding this comment.
Yeah. Did not pass my threshold, the convenience of having all sosfilt testing in a class won over, fwiw.
Can rework, of course, if you've a strong opinion to the contrary?
|
This PR looks "ok" to me, but I believe I found a few issues with the origina/precedent PR in the cross-listed ticket. I'll label that good first issue, since they look like copy-paste errors mostly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to gh-21211: we deprecated object arrays as inputs to
lfilter, but forgot or did not know aboutsosfilt. These two should probably be in sync, hence follow the lfilter deprecation in sosfilt.