Skip to content

Conversation

musvaage
Copy link
Contributor

@lucascolley

dumped directory strings exposed a few typos

@github-actions github-actions bot added scipy.linalg Cython Issues with the internal Cython code base Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org maintenance Items related to regular maintenance tasks labels Sep 24, 2024
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good modulo one file

Copy link
Member

@rkern rkern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other changes LGTM.

@lucascolley
Copy link
Member

snap :)

@musvaage musvaage marked this pull request as draft September 24, 2024 19:08
@musvaage musvaage marked this pull request as ready for review September 24, 2024 19:19
@lucascolley lucascolley added this to the 1.15.0 milestone Sep 24, 2024
@lucascolley lucascolley removed the Cython Issues with the internal Cython code base label Sep 24, 2024
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@lucascolley lucascolley merged commit eee9de7 into scipy:main Sep 24, 2024
33 of 35 checks passed
@musvaage
Copy link
Contributor Author

In the scipy/optimize tree any sudirectories to skip or specific file types regarding typo checking?

@lucascolley
Copy link
Member

consult gh-21232 for vendored code that shouldn't be touched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org maintenance Items related to regular maintenance tasks scipy.linalg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants