Skip to content

DOC/MAINT: stats: fix some typos #21573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2024
Merged

DOC/MAINT: stats: fix some typos #21573

merged 1 commit into from
Sep 17, 2024

Conversation

musvaage
Copy link
Contributor

cf: #19295 (comment)

per request will revert changes to the C code

WONT' FIX

$ grep -nr awailable scipy
scipy/scipy/stats/biasedurn/stoc3.cpp:802:   For further documentation see nchyp.pdf, awailable from www.agner.org/random
$ grep -nr consequtive scipy/scipy/stats
scipy/scipy/stats/biasedurn/wnchyppr.cpp:832:   int converg = 0;              // number of consequtive terms below accuracy
scipy/scipy/stats/biasedurn/wnchyppr.cpp:1607:   int converg = 0;                    // number of consequtive terms below accuracy
$ grep -nr obtimized scipy/scipy/stats
scipy/scipy/stats/biasedurn/stoc3.cpp:329:   // and one for up search, because they are obtimized for consecutive x values.
$

@github-actions github-actions bot added scipy.stats C/C++ Items related to the internal C/C++ code base labels Sep 17, 2024
rkern
rkern approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@rkern rkern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

For future PRs, please take a look at our documentation concerning git commit messages. Thanks!

@musvaage
Copy link
Contributor Author

musvaage commented Sep 17, 2024 •
edited
Loading

git commit messages

e.g.

MAINT: doc: typos
DOC/MAINT: doc: fix some typos

Time permitting can your reply as to whether any of the following files should be left untouched?

$ cat typos.sh
#!/bin/sh

sed -i "s/alongsize/alongside/g" scipy/doc/source/release/1.3.0-notes.rst
sed -i "s/aymptotic/asymptotic/g" scipy/doc/source/tutorial/stats/hypothesis_fligner.md
sed -i "s/aymptotic/asymptotic/g" scipy/doc/source/tutorial/stats/hypothesis_bartlett.md
sed -i "s/aymptotic/asymptotic/g" scipy/doc/source/tutorial/stats/hypothesis_normaltest.md
sed -i "s/aymptotic/asymptotic/g" scipy/doc/source/tutorial/stats/hypothesis_skewtest.md
sed -i "s/aymptotic/asymptotic/g" scipy/doc/source/tutorial/stats/hypothesis_jarque_bera.md
sed -i "s/aymptotic/asymptotic/g" scipy/doc/source/tutorial/stats/hypothesis_spearmanr.md
sed -i "s/aymptotic/asymptotic/g" scipy/doc/source/tutorial/stats/hypothesis_kurtosistest.md
sed -i "s/aymptotic/asymptotic/g" scipy/doc/source/tutorial/stats/hypothesis_kendalltau.md
sed -i "s/aymptotic/asymptotic/g" scipy/doc/source/tutorial/stats/hypothesis_levene.md
sed -i "s/definifing/defining/g" scipy/doc/source/tutorial/interpolate/smoothing_splines.rst
sed -i "s/guassian/gaussian/g" scipy/doc/source/release/1.5.0-notes.rst
sed -i "s/intepreter/interpreter/g" scipy/doc/source/release/1.4.0-notes.rst
sed -i "s/iterpolation/interpolation/g" scipy/doc/source/release/0.18.0-notes.rst
sed -i "s/optizimation/optimization/g" scipy/doc/source/release/1.2.0-notes.rst
sed -i "s/pre-emptive/preemptive/g" scipy/doc/source/building/redistributable_binaries.rst
sed -i "s/prety-printed/pretty-printed/g" scipy/doc/source/building/introspecting_a_build.rst
sed -i "s/sparce/sparse/g" scipy/doc/source/release/1.9.0-notes.rst
sed -i "s/statisics/statistics/g" scipy/doc/source/dev/contributor/adding_new/new_stats_distribution.rst.inc
sed -i "s/superceded/superseded/g" scipy/doc/source/release/0.18.0-notes.rst
sed -i "s/surpport/support/g" scipy/doc/source/dev/api-dev/array_api.rst
sed -i "s/thesame/the same/g" scipy/doc/source/release/1.4.0-notes.rst
$

@lucascolley lucascolley changed the title stats (typos) DOC/MAINT: stats: fix some typos Sep 17, 2024
@lucascolley
Copy link
Member

for the release notes files, you shouldn't make a change to a title of a PR or issue. But you can fix typos in descriptions of what had changed in that release.

The other files look fine to change I think.

@musvaage
Copy link
Contributor Author

shouldn't make a change to a title of a PR or issue

that was rather obvious

WON'T FIX

$ sed -n '1032p' scipy/doc/source/release/1.9.0-notes.rst
* `#15835 <https://github.com/scipy/scipy/pull/15835>`__: FIX: Incorect boschloo pvalue
$

lucascolley
lucascolley approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@lucascolley lucascolley added this to the 1.15.0 milestone Sep 17, 2024
@lucascolley lucascolley added Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org maintenance Items related to regular maintenance tasks and removed C/C++ Items related to the internal C/C++ code base labels Sep 17, 2024
@lucascolley lucascolley merged commit 7be13dc into scipy:main Sep 17, 2024
38 of 40 checks passed
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 18, 2024
@DimitriPapadopoulos
More typos found in Scipy
38158be 
scipy/scipy#21573
scipy/scipy#21575
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 18, 2024
@DimitriPapadopoulos
More typos found in Scipy
f9ac1db 
scipy/scipy#21573
scipy/scipy#21575
@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Sep 18, 2024
Merged
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 27, 2024
@DimitriPapadopoulos
Typos found in Scipy
1a12f26 
scipy/scipy#21573
scipy/scipy#21585
scipy/scipy#21586
scipy/scipy#21607
scipy/scipy#21617
scipy/scipy#21621
scipy/scipy#21624
scipy/scipy#21634
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 27, 2024
@DimitriPapadopoulos
Typos found in Scipy
e13de7a 
scipy/scipy#21573
scipy/scipy#21575
scipy/scipy#21585
scipy/scipy#21586
scipy/scipy#21607
scipy/scipy#21617
scipy/scipy#21621
scipy/scipy#21624
scipy/scipy#21634
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 27, 2024
@DimitriPapadopoulos
More typos found in Scipy
c5d434c 
scipy/scipy#21573
scipy/scipy#21575
scipy/scipy#21585
scipy/scipy#21586
scipy/scipy#21607
scipy/scipy#21617
scipy/scipy#21621
scipy/scipy#21624
scipy/scipy#21634
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 27, 2024
@DimitriPapadopoulos
More typos found in Scipy
52a8242 
scipy/scipy#21573
scipy/scipy#21575
scipy/scipy#21585
scipy/scipy#21586
scipy/scipy#21607
scipy/scipy#21617
scipy/scipy#21621
scipy/scipy#21624
scipy/scipy#21634
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 27, 2024
@DimitriPapadopoulos
More typos found in Scipy
5a620ba 
scipy/scipy#21573
scipy/scipy#21575
scipy/scipy#21585
scipy/scipy#21586
scipy/scipy#21607
scipy/scipy#21617
scipy/scipy#21621
scipy/scipy#21624
scipy/scipy#21634
DimitriPapadopoulos added a commit to codespell-project/codespell that referenced this pull request Sep 27, 2024
@DimitriPapadopoulos
More typos found in Scipy
31ceeed 
scipy/scipy#21573
scipy/scipy#21575
scipy/scipy#21585
scipy/scipy#21586
scipy/scipy#21607
scipy/scipy#21617
scipy/scipy#21621
scipy/scipy#21624
scipy/scipy#21634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkern rkern rkern approved these changes

@lucascolley lucascolley lucascolley approved these changes

@tupui tupui Awaiting requested review from tupui tupui is a code owner

@mdhaber mdhaber Awaiting requested review from mdhaber mdhaber is a code owner

Assignees
No one assigned
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org maintenance Items related to regular maintenance tasks scipy.stats
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@musvaage @lucascolley @rkern