MAINT: constants: slim down module, part 2 #20430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to be clear @jakobjakobson13 - out of this PR, gh-17584, and gh-17577, which of them:
The situation with these PRs is a little confusing and 'follow up' is a bit vague. Thanks! |
|
I'm closing this one as it's too disruptive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Follow up of #17577
What does this implement/fix?
It would slim down the constants module drastically introducing major compatibility issues (as functions and constants were removed). So, feel free to either reject or take as an inspiration. That´s up to you.
Additional information
The testing definitely needs (more) work. Apart from that, it would be nice if #17584 and/or #11345 could be included in scipy.