DEP: stats.mode: raise with non-numeric input #18290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
commented
Apr 13, 2023
| @@ -501,6 +501,12 @@ def mode(a, axis=0, nan_policy='propagate', keepdims=False): | |||
|
|
|||
| """ # noqa: E501 | |||
| # `axis`, `nan_policy`, and `keepdims` are handled by `_axis_nan_policy` | |||
| if not np.issubdtype(a.dtype, np.number): | |||
| message = ("Argument `a` is not recognized as numeric. " | |||
There was a problem hiding this comment.
Phrased like this to reduce confusion when the input appears to be numeric but isn't coerced to numeric type (e.g. Series with pandas integers).
There was a problem hiding this comment.
are you intending to drop bool on purpose here?
There was a problem hiding this comment.
Yes, for now. The deprecation warning was produced under the same conditions as the error message would be with this PR, so it should be OK.
|
I think there are some more place to be cleaned up in scipy/scipy/stats/tests/test_stats.py Lines 2295 to 2299 in c62be9c scipy/scipy/stats/tests/test_stats.py Line 2212 in c62be9c |
j-bowhay
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
#18254 (comment)
What does this implement/fix?
One resolution of gh-18245 was that
stats.modeshould raise when input is non-numeric. This implements that.