Skip to content

DEP: deprecate positional arguments for some methods in sparse.linalg… #18934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2023
Merged

DEP: deprecate positional arguments for some methods in sparse.linalg… #18934

merged 1 commit into from
Jul 22, 2023

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Jul 22, 2023 •
edited
Loading

…._isolve

Those that have upcoming signature changes anyway

Closes #18577, towards #18703

Question here is whether we want to change the signatures of gcrotmk, lgmres, minres, tfqmr as well. I think it would be good to have it homogeneous, but for now I'm only tackling the functions whose signatures were changed.

@h-vetinari
DEP: deprecate positional arguments for some methods in sparse.linalg…
6bd7f20 
…._isolve

Those that have upcoming signature changes anyway
@ilayn
Copy link
Member

ilayn commented Jul 22, 2023

Agreed for adding gcrotmk, lgmres, minres, tfqmr. The artificial separation was due to Fortran removal efforts, but there is no distinction among these anymore.

@j-bowhay j-bowhay added this to the 1.12.0 milestone Jul 22, 2023
@j-bowhay j-bowhay added the deprecated Items related to behavior that has been deprecated label Jul 22, 2023
@j-bowhay j-bowhay merged commit c8069d9 into scipy:main Jul 22, 2023
@h-vetinari h-vetinari deleted the positional_isolve branch July 22, 2023 21:59
@h-vetinari
Copy link
Member Author

This shouldn't have been merged yet IMO, I wanted to discuss if we should make this consistent with the other solvers (and @ilayn agreed, but I haven't had time to get to my laptop since then).

Could you raise a PR that tackles the remaining solvers @j-bowhay?

@j-bowhay
Copy link
Member

Apologies I had assumed you intended that for a follow-up but yes happy to

@j-bowhay j-bowhay mentioned this pull request Jul 23, 2023
Merged
This was referenced Jul 28, 2023
Open
Open
@h-vetinari h-vetinari mentioned this pull request Dec 18, 2023
Open
@h-vetinari h-vetinari mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-bowhay j-bowhay j-bowhay approved these changes

Assignees
No one assigned
Labels
deprecated Items related to behavior that has been deprecated scipy.sparse.linalg scipy.sparse
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

DEP: deprecate positional arguments in sparse.gmres
3 participants
@h-vetinari @ilayn @j-bowhay