MAINT: stats: remove support for _rvs without size parameter
#15917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
commented
Apr 1, 2022
h-vetinari
approved these changes
Apr 2, 2022
tupui
reviewed
Apr 2, 2022
tupui
reviewed
Apr 2, 2022
patnr
added a commit
to patnr/scipy
that referenced
this pull request
Apr 5, 2022
* master: (632 commits) Update _dual_annealing.py (scipy#15939) TST: stats: make `check_sample_var` two-sided (scipy#15723) DOC: sparse.linalg: add citations for COLAMD DOC: fix missing comma in conf ENH/MAINT: Version switcher from the sphinx theme (scipy#15380) MAINT: stats: remove support for `_rvs` without `size` parameter (scipy#15917) BUG: Handle base case for scipy.integrate.simpson when span along the axis is 0 (scipy#15824) MAINT: stats: adjust tolerance for failing test only MAINT: stats: adjust tolerance of failing TestTruncnorm MAINT: special: Clean up C style in ndtr.c CI: remove pin on Jinja2 (scipy#15895) STY: Remove white spaces MAINT: stats: exempt gilbrat from refguide_check MAINT: stats: rename continuous_gilbrat->continuous_gibrat MAINT: stats: correct name Gilbrat -> Gibrat [ENH] circvar calculated simply as 1-R (scipy#5747) DEP: deal with deprecation of ndim >1 in bspline MAINT: stats: more specific error type from `rv_continuous.fit` (scipy#15778) DOC: fix import in example in _morestats (scipy#15900) [BUG] make p-values consistent with the literature (scipy#15894) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes gh-15747
gh-11394
What does this implement/fix?
gh-11394 deprecated the ability to implement
_rvswithout asizeparameter._rvsis a private method, but it's in a public class, so immediate removal of support for_rvswithout asizeparameter had backward-compatibility concerns. The authors added special treatment for_rvsmethods without asizeparameter, but this can be removed now that a deprecation warning has been raised for years. This PR now always passessizewhenrvscalls_rvs, and it tests that there is an error (rather than deprecation warning) when an_rvsmethod that does not acceptsizegets passedsize.Additional information
gh-11394 suggested that it was supposed to do something similar w.r.t.
random_state: remove reliance of_rvsmethods on a_random_stateattribute and instead require that they accept arandom_stateparameter. However, it did not raise a deprecation warning for_rvsmethods that don't acceptrandom_state, and_random_stateis still used throughout the distribution infrastructure, so I didn't touch that.