CI: remove pin on Jinja2 #15895
Merged
CI: remove pin on Jinja2 #15895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip actions] [skip circle]
|
@rossbar seems like the issue is still there with the new version of numpydoc (1.2): Traceback (most recent call last):
File "/home/vsts/work/1/s/tools/refguide_check.py", line 46, in <module>
from numpydoc.docscrape_sphinx import get_doc_object
File "/opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/site-packages/numpydoc/docscrape_sphinx.py", line 11, in <module>
from sphinx.jinja2glue import BuiltinTemplateLoader
File "/opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/site-packages/sphinx/jinja2glue.py", line 15, in <module>
from jinja2 import FileSystemLoader, BaseLoader, TemplateNotFound, contextfunction
ImportError: cannot import name 'contextfunction' from 'jinja2' (/opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/site-packages/jinja2/__init__.py) |
|
Okay the root issue is reported here: sphinx-doc/sphinx#10291. Jinja 3.1.X (released ~5 days ago) is incompatible with sphinx 2.X and 3.X and the failing CI jobs look like they install sphinx 2.1.
|
|
Nice and looks like you already have a release, let's try! |
[skip actions] [skip circle]
|
Now working fine ( |
patnr
added a commit
to patnr/scipy
that referenced
this pull request
Apr 5, 2022
* master: (632 commits) Update _dual_annealing.py (scipy#15939) TST: stats: make `check_sample_var` two-sided (scipy#15723) DOC: sparse.linalg: add citations for COLAMD DOC: fix missing comma in conf ENH/MAINT: Version switcher from the sphinx theme (scipy#15380) MAINT: stats: remove support for `_rvs` without `size` parameter (scipy#15917) BUG: Handle base case for scipy.integrate.simpson when span along the axis is 0 (scipy#15824) MAINT: stats: adjust tolerance for failing test only MAINT: stats: adjust tolerance of failing TestTruncnorm MAINT: special: Clean up C style in ndtr.c CI: remove pin on Jinja2 (scipy#15895) STY: Remove white spaces MAINT: stats: exempt gilbrat from refguide_check MAINT: stats: rename continuous_gilbrat->continuous_gibrat MAINT: stats: correct name Gilbrat -> Gibrat [ENH] circvar calculated simply as 1-R (scipy#5747) DEP: deal with deprecation of ndim >1 in bspline MAINT: stats: more specific error type from `rv_continuous.fit` (scipy#15778) DOC: fix import in example in _morestats (scipy#15900) [BUG] make p-values consistent with the literature (scipy#15894) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin was added in #15868 and since #15443 it can be removed.