DOC, MAINT: Remove numpydoc submodule #15789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupui
reviewed
Mar 15, 2022
| @@ -3,4 +3,5 @@ | |||
| Sphinx!=3.1.0, !=4.1.0 | |||
| pydata-sphinx-theme>=0.6.1 | |||
| sphinx-panels>=0.5.2 | |||
| numpydoc==1.1 | |||
There was a problem hiding this comment.
Any reason for the pinned version?
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok sure if there are blockers. Otherwise as you can see from the other doc dependencies there is no pin. Just versions to skip.
|
After discussing this on our last meeting, I propose to merge this at the end of the week (2022-3-25) if there are no further comments. |
|
No complains, it's Friday, merging. Thanks again @rossbar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates how the scipy documentation uses numpydoc; removing numpydoc as a git submodule and instead relying on the released version as a dependency.
numpydocis already listed as a dependency in most relevant places (pyproject.toml, variousenvironmentsfiles). This PR completes the process by removing the git submodule and various other manual shims and references.Reference issue
There is no reference issue, but this was discussed in the scipy community meeting.
What does this implement/fix?
Updates/simplifies how the numpydoc doc dependency is managed.
Additional information
Note that explicit testing against scipy is part of the release process for numpydoc.