ENH: optimize: milp: mixed integer linear programming #15460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
commented
Jan 23, 2022
There was a problem hiding this comment.
Here are fixes for most test failures. Still need to fix Meson build failure
Run pushd tools
~/work/scipy/scipy/tools ~/work/scipy/scipy
Traceback (most recent call last):
File "/home/runner/work/scipy/scipy/tools/check_installation.py", line 74, in <module>
main(install_dir)
File "/home/runner/work/scipy/scipy/tools/check_installation.py", line 49, in main
raise Exception("%s is not installed" % scipy_test_files[test_file])
Exception: /home/runner/work/scipy/scipy/scipy/optimize/tests/test_milp.py is not installed
Error: Process completed with exit code 1.
mdhaber
commented
Jan 23, 2022
mdhaber
commented
Jan 23, 2022
mckib2
reviewed
Jan 23, 2022
mckib2
reviewed
Jan 24, 2022
mckib2
reviewed
Jan 24, 2022
mckib2
reviewed
Jan 24, 2022
mckib2
reviewed
Jan 24, 2022
mckib2
reviewed
Jan 24, 2022
mckib2
reviewed
Jan 24, 2022
mdhaber
commented
Jan 24, 2022
[skip ci]
rgommers
reviewed
Jan 24, 2022
[skip actions][skip azp]
[skip actions][skip azp] Co-authored-by: Pamphile Roy <roy.pamphile@gmail.com>
mdhaber
commented
Jan 26, 2022
[skip actions][skip azp]
|
Thanks for the thoughts @tupui; I committed all of your suggestions and implemented most of the other ideas. There were a few things that needed some more discussion. Please resolve discussions that you're happy with and let me know your thoughts on the rest. (BTW I skipped tests because the were passing before and not much has changed. We'll run them all again before merge.) |
Nope, but there are a few things this is waiting on:
|
mckib2
reviewed
Jan 28, 2022
fuglede
reviewed
Feb 9, 2022
…rrectly [skip azp] [skip actions]
|
Thanks everyone. I suppose we can mark this as a release highlight. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes gh-14455
gh-15294
gh-9269
What does this implement/fix?
In gh-15294, we exposed HiGHS MILP features by adding the
integralityparameter tolinprog. In gh-14455, however, the consensus was that MILP also deserved its own function. This PR adds a newmilpfunction dedicated to mixed integer linear programming.Additional information
gh-15394 should merge first.