MAINT: two small fixes for implicit scalar-array-conversions #14278
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 22, 2021
|
How can I retrigger the build? (I'm assuming the test failure was a blooper.) |
|
Safe to ignore the Azure Windows timeouts for now I think, we've been seeing them a fair bit. |
|
Let me know if there's anything I can do to improve this PR. |
|
@nschloe there is something wrong with your PR. The git history seems off. Can you rebase your commits onto master to fix this? |
|
Yeah I just noticed. I'm on it. |
0026f96 to
011d3bb
Compare
|
Fixed now. Would be happy about a review here! 😃 |
There was a problem hiding this comment.
Looked at #13864 and both the changes here seem in line with it. I just have one question.
tirthasheshpatel
approved these changes
Aug 16, 2021
There was a problem hiding this comment.
I don't have any other comments. Pretty straightforward fixes. Thanks, @nschloe!
|
Feel free to merge @tirthasheshpatel :) |
tylerjereddy
approved these changes
Aug 17, 2021
|
thanks @nschloe et al. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last bit of #13864. Two small clean-ups.