ENH: cluster: add an optional argument seed for kmeans and kmeans2 to set random generator and random state.
#13972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to set random generator and random state.
tupui
reviewed
May 2, 2021
There was a problem hiding this comment.
Good addition, thanks! A few minor things on my side.
Also, I am not sure what we should use in the future to name RNG. seed or random_state or something else? @mdhaber @WarrenWeckesser (we could add this to your PR about best practice)?
Co-authored-by: Pamphile ROY <roy.pamphile@gmail.com>
Co-authored-by: Pamphile ROY <roy.pamphile@gmail.com>
Co-authored-by: Pamphile ROY <roy.pamphile@gmail.com>
Co-authored-by: Pamphile ROY <roy.pamphile@gmail.com>
Co-authored-by: Pamphile ROY <roy.pamphile@gmail.com>
tupui
reviewed
May 3, 2021
tupui
approved these changes
May 4, 2021
tupui
reviewed
May 4, 2021
|
The timeout are unrelated and seen in other PRs so merging. Thanks again @AtsushiSakai |
This was referenced Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
fix #9450
What does this implement/fix?
I added an optional argument
seedforkmeansandkmeans2to set random generator and random state.I also added tests for these and updated docs.