Skip to content

BUG: constants: fix 'exact' values table #11343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2020
Merged

BUG: constants: fix 'exact' values table #11343

merged 2 commits into from
May 20, 2020

Conversation

pv
Copy link
Member

@pv pv commented Jan 10, 2020

Reference issue

See gh-11341

What does this implement/fix?

Restore 'exact' values removed in f166e3a

The vacuum permeabilities and permittivities are no longer exact in
CODATA 2018, so add their old names as aliases (CODATA2018 lists the
atomic unit separately).

The characteristic impedance of vacuum is also not exact, so specify the
old 'exact' value manually.

Also make the 'exact values' override system deal with overriding obsolete values.

@tylerjereddy tylerjereddy added scipy.constants defect A clear bug or issue that prevents SciPy from being installed or used as expected backport-candidate This fix should be ported by a maintainer to previous SciPy versions. labels Jan 11, 2020
@pv pv force-pushed the constants-exact-values branch from 69ff1fc to d4f32bf Compare January 16, 2020 17:27
@jakobjakobson13 jakobjakobson13 mentioned this pull request Feb 18, 2020
Closed
@pvanmulbregt pvanmulbregt mentioned this pull request Feb 20, 2020
Closed
19 tasks
@pvanmulbregt pvanmulbregt mentioned this pull request Mar 10, 2020
Merged
@jakobjakobson13 jakobjakobson13 mentioned this pull request Mar 18, 2020
Closed
pv added 2 commits April 10, 2020 19:58
@pv
MAINT: constants: make the exact values override system deal with obs…
4ab1da5 
…olete valued

The setup should be able to override obsolete CODATA values.
@pv
BUG: constants: fix 'exact' values table
a3ff463 
Restore 'exact' values removed in f166e3a

The vacuum permeabilities and permittivities are no longer exact in
CODATA 2018, so add their old names as aliases (CODATA2018 lists the
atomic unit separately).

The characteristic impedance of vacuum is also not exact, so specify the
old 'exact' value manually.
@pv pv force-pushed the constants-exact-values branch from d4f32bf to a3ff463 Compare April 10, 2020 16:58
@rgommers
Copy link
Member

Thanks @pv. @jakobjakobson13 would you mind reviewing this?

@rgommers rgommers added this to the 1.5.0 milestone Apr 26, 2020
@jakobjakobson13
Copy link
Contributor

I'm a bit busy at the moment, so it could take a week or two till I get to it. If that's no problem, I'd be honoured to do it even though I'm surprised that you ask me as I introduced the bug #11341 with my commit.

@rgommers
Copy link
Member

even though I'm surprised that you ask me as I introduced the bug #11341 with my commit.

No worries, it's not a major bug and I missed it in review too. You have spent more time on constants than anyone else has in years, so it'd be great to have your input.

@jakobjakobson13
Copy link
Contributor

@pv As I understand your pull requests #11345 is a more complete pull request than this one. So should we review this one as well or should we only go for #11345 ?

@pv
Copy link
Member Author

pv commented May 9, 2020 •
edited
Loading

We can put this in first, imo, I'll rebase the other one afterward.
1.5.0 is close, so it may be better to postpone the more involved revision after that.

@tylerjereddy
Copy link
Contributor

Ok, CI is green and I'd like to avoid the huge revision PR follow-up to this ~6 days before branching so let's do as Pauli suggests and merge this one.

I don't see any objections to the changes in the discussion above, apart from noting that these changes will eventually be superseded by the bigger PR.

It may have been nice to see CI fail before/pass after for the constants issue being addressed. If the cross-listed issue is to be closed please do put a milestone on it too.

@tylerjereddy tylerjereddy merged commit 1c3ca9f into scipy:master May 20, 2020
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jul 31, 2020
@akern40 akern40 mentioned this pull request Apr 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.constants
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pv @rgommers @jakobjakobson13 @tylerjereddy