BUG: Fix _lib._util.getargspec_no_self KEYWORD_ONLY support. #11417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In _lib._util.get_argspec_no_self(): * return POSITIONAL_ONLY arguments in the args element of the ArgSpec tuple. * raise ValueError if the method has keyword-only arguments (matches behaviour of Python's inspect.getargspec). Add _util.getfullargspec_no_self to match inspect.getfullargspec. Use _util.getfullargspec_no_self in stats.rv_generic.__init__ when checking for the presence of the 'moment' keyword in the distribution's ._stats method. Added tests of get_argspec_no_self and getfullargspec_no_self to _lib/tests/test__util.py If get_argspec_no_self would return incomplete information it will raise an Exception instead. This should solve the backwards compatibility issue, in that older code using it will still work if it can, and break if it would fail.
|
Maybe just ditch It's only used in a handful of places in the codebase, and it's an internal function (from |
This now accepts row-vector 2d arrays in addition to 1d arrays. Fixes scipygh-11255
This updates the pypocketfft version to include pypocketfft!31 which fixes the `thread` name collisions on AIX and hopefully all future collisions by removing uses of `using namespace std;` from Martin's code. Also fixes vectorization on clang and correct detection of AppleClang.
Fix comparison between pydata sparse arrays and sparse matrices.
* add optional argment, nyquist, for freqz * fixed codes based on reviews. * add docstring based on review * fix docstring based on review
MAINT: check minimize duplicate evaluations
* add a plan argument to FFT functions in scipy.fft * add docstrings * move NotImplementedError to _pocketfft * add tests test 1. scipy.fft does not support plan, and 2. a customized backend can accept plan. * add versionadded
DOC: revert gh10540, numpy intersphinx update
This reverts commit e43dd8e.
* the latest stable version of gcc toolchain installed via homebrew was interfering with the Travis CI Python 3.7 Mac OSX build when latest version of multibuild submodule was installed * fix this by removing the super-new version of gcc toolchain from brew
The inequality in the docstring should be reversed, fixes scipy#11428 .
* document/fix sequence of modes support in ndimage filters The underlying C code does not support a sequence of modes, so only separable filters should allow a sequence of modes. * check mode sequence prior to _extend_mode_to_code call * TST: append to rather than replace existing tests * fix variable name * use isinstance(..., Iterable) rather than hasattr(..., '__iter__')
Removed getargspec_no_self
|
Took Evgeni's advice and dumped |
|
Something went south with a rebase? |
Looks like it. |
|
Closing due to rebase problem. Replace with gh-11455. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Closes gh-11416
What does this implement/fix?
_lib._util.get_argspec_no_self():POSITIONAL_ONLYarguments in the args element of the ArgSpec tuple.of Python's
inspect.getargspec)._util.getfullargspec_no_selfto matchinspect.getfullargspec._util.getfullargspec_no_selfinstats.rv_generic.__init__when checkingfor the presence of the 'moment' keyword in the distribution's
._statsmethod.get_argspec_no_selfandgetfullargspec_no_selfto_lib/tests/test__util.pyIf
get_argspec_no_selfwould return incomplete information it will raise anException instead. This should solve the backwards compatibility issue, in
that older code using it will still work if it can, and break if it would fail.