BUG: sparse.linalg/gmres: deprecate effect of callback on semantics of maxiter #10341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @pv, adding |
…f maxiter Previously, specifying a `callback` argument to gmres would change the meaning of `maxiter`. This is clearly undesired. Deprecate the old 'legacy' behavior by adding a new `callback_type` argument. Code that does not specify it will get a warning emitted, but will retain the old behavior. The 'x' callback type will not be called on inner iterations: the optimal residual vector is not yet computed at that point. The behavior of lgmres, gcrotmk is the same.
|
No further comments, so merged. Thanks @pv |
toslunar
added a commit
to toslunar/cupy
that referenced
this pull request
Dec 3, 2020
scipy/scipy#10341 added the `callback_type` arg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, specifying a
callbackargument to gmres would change themeaning of
maxiter. This is clearly undesired.Deprecate the old 'legacy' behavior by adding a new
callback_typeargument. Code that does not specify it will get a warning emitted, but
will retain the old behavior.
In #1255 it is claimed
maxiterdid not work without theiter_numstuff ---however, I believe this is false: the
iter_numis incremented only whencallbackis given. So ifmaxiterdid not work, this would always manifestwhen
callbackwas not provided. However, there are no bug reports of thishappening, nor can I reproduce it.
Closes: #8815
Closes: #1255