Skip to content

topology: simplify format #3741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2020
Merged

topology: simplify format #3741

merged 2 commits into from
Apr 30, 2020

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Apr 30, 2020 •
edited by kormat
Loading

This is a BREAKING CHANGE.
The topology format is simplified quite a bit:

  • Only allow single address per service.
  • Port and IP is merged in the same field.
  • Remove/rename overlay -> underlay. (remove where not needed, rename where appropriate).
  • Remove TTL, it's not needed anymore.
  • Convert to snake_case

Fixes #2923

This change is Reviewable

@lukedirtwalker
topogen: pre-allocate addresses (scionproto#2783)
5648644 
We want to change the topology format in the future
and for this change we will need the IP address of a service in the generate functions.
This is a preparation PR for this.

We first register all the addresses we will need, then generate the addresses, then generate the services.
@lukedirtwalker
topology: simplify format
1974685 
This is a BREAKING CHANGE.
The topology format is simplified quite a bit:
- Only allow single address per service.
- Port and IP is merged in the same field.
- Remove/rename overlay -> underlay. (remove where not needed, rename where appropriate).
- Remove TTL, it's not needed anymore.
- Convert to snake_case

Fixes scionproto#2923
@lukedirtwalker lukedirtwalker added the i/breaking change PR that breaks forwards or backwards compatibility label Apr 30, 2020
@lukedirtwalker lukedirtwalker requested a review from oncilla April 30, 2020 05:13
oncilla
oncilla approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 46 of 46 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit 2ab773f into scionproto:master Apr 30, 2020
@lukedirtwalker lukedirtwalker deleted the pubOpnTopo branch April 30, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oncilla oncilla oncilla approved these changes

Assignees
No one assigned
Labels
i/breaking change PR that breaks forwards or backwards compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON Format: Use snake_case
2 participants
@lukedirtwalker @oncilla