Skip to content

SIG: Move sig.json parsing into a shared library #3688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2020
Merged

SIG: Move sig.json parsing into a shared library #3688

merged 1 commit into from
Mar 13, 2020

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Mar 13, 2020 •
edited by kormat
Loading

This change is Reviewable

sgmonroy
sgmonroy approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@sgmonroy sgmonroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sustrik sustrik merged commit 3ea1e85 into scionproto:master Mar 13, 2020
@sustrik sustrik deleted the sigjsonlib-os branch March 13, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sgmonroy sgmonroy sgmonroy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sgmonroy sgmonroy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sustrik @sgmonroy