Skip to content

SIG: Make the snet connection in ingress.Dispatcher mockable #3659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2020
Merged

SIG: Make the snet connection in ingress.Dispatcher mockable #3659

merged 1 commit into from
Feb 7, 2020

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Feb 7, 2020 •
edited by kormat
Loading

This change is Reviewable

@sustrik sustrik requested a review from sgmonroy February 7, 2020 11:18
sgmonroy
sgmonroy approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@sgmonroy sgmonroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sustrik sustrik merged commit f80a268 into scionproto:master Feb 7, 2020
@sustrik sustrik deleted the ingress branch February 10, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sgmonroy sgmonroy sgmonroy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sustrik @sgmonroy