Skip to content

godispatcher: Split out a library that could be linked into apps #3634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2020
Merged

godispatcher: Split out a library that could be linked into apps #3634

merged 1 commit into from
Jan 23, 2020

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Jan 23, 2020 •
edited by kormat
Loading

This change is Reviewable

@sustrik sustrik changed the title godispatcher: Split out a library that could be linked into apps (#1841) godispatcher: Split out a library that could be linked into apps Jan 23, 2020
scrye
scrye approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 11 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sustrik sustrik merged commit 06931f6 into scionproto:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@scrye scrye scrye approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sustrik @scrye