Skip to content

Remove forgotten configuration types from beacon_srv #3603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2020
Merged

Remove forgotten configuration types from beacon_srv #3603

merged 1 commit into from
Jan 14, 2020

Conversation

juagargi
Copy link
Contributor

@juagargi juagargi commented Jan 13, 2020 •
edited by kormat
Loading

The types BSConfig and Policies were forgotten inside beacon_srv/internal/config.

This change is Reviewable

@scrye scrye self-assigned this Jan 14, 2020
@scrye scrye self-requested a review January 14, 2020 08:09
scrye
scrye approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scrye scrye merged commit 1352c6c into scionproto:master Jan 14, 2020
@juagargi juagargi deleted the superfluous_config branch January 14, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@scrye scrye scrye approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@scrye scrye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juagargi @scrye