CPPKI: Polishing the TRC and certificate format #3602
Conversation
There was a problem hiding this comment.
Reviewed 15 of 71 files at r1.
Reviewable status: 15 of 71 files reviewed, all discussions resolved (waiting on @scrye)
There was a problem hiding this comment.
Reviewed 56 of 71 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @oncilla and @scrye)
go/lib/infra/modules/trust/trustdbsqlite/db.go, line 190 at r1 (raw file):
} func (e *executor) GetIssuingKeyInfo(ctx context.Context, ia addr.IA,
I think this will also be renamed to GetIssuingGrantKeyInfo to be consistent
go/tools/scion-pki/internal/conf/issuer.go, line 44 at r1 (raw file):
Description string `toml:"description"` Version scrypto.Version `toml:"version"` IssuingKeyVersion *scrypto.KeyVersion `toml:"issuing_grant_key_version"`
I think it would be cleaner to also fix the name here.
go/tools/scion-pki/internal/trcs/testdata/ISD1/ASff00_0_110/keys.toml, line 8 at r1 (raw file):
not_before = 1573033769 validity = "1y" [primary.offline]
this should also have voting_offline and voting_online
go/tools/scion-pki/internal/trcs/testdata/ISD1/ASff00_0_130/keys.toml, line 8 at r1 (raw file):
not_before = 1573033769 validity = "1y" [primary.offline]
this should also have voting_offline and voting_online
0f9b50b to
35471d9
Compare
There was a problem hiding this comment.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @lukedirtwalker and @scrye)
go/lib/infra/modules/trust/trustdbsqlite/db.go, line 190 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
I think this will also be renamed to
GetIssuingGrantKeyInfoto be consistent
Done.
go/tools/scion-pki/internal/conf/issuer.go, line 44 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
I think it would be cleaner to also fix the name here.
Done.
go/tools/scion-pki/internal/trcs/testdata/ISD1/ASff00_0_110/keys.toml, line 8 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
this should also have
voting_offlineandvoting_online
Done.
go/tools/scion-pki/internal/trcs/testdata/ISD1/ASff00_0_130/keys.toml, line 8 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
this should also have
voting_offlineandvoting_online
Done.
renames: - offline to voting_offline key - online to voting_online key - issuing key in TRC to issuing_grant key - ia to isd_as in the AS certificate remove redundant information in the TRC votes. fixes scionproto#3142
35471d9 to
5fa0704
Compare
There was a problem hiding this comment.
Reviewed 18 of 18 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @scrye)
renames:
remove redundant information in the TRC votes.
fixes #3142
This change is