Add IPv6 ASes to test topology #3593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrye
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Add the possibility to specify the underlay in the topo file format. Change the topology generator to support the new option. With this we test IPv4 and IPv6 ASes in the CI integration. Also remove bind support from the generator, it is no longer supported by Go services. Fixes scionproto#2775
ec87667 to
395f8db
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to specify the underlay in the topo file format.
Change the topology generator to support the new option.
With this we test IPv4 and IPv6 ASes in the CI integration.
Also remove bind support from the generator, it is no longer supported by Go services.
Fixes #2775
This change is