-
Notifications
You must be signed in to change notification settings - Fork 173
CI: Delete old pipeline and associated files #3581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Delete old pipeline and associated files #3581
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 27 of 27 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @lukedirtwalker)
a discussion (no related file):
This PR misses a description how the new pipeline can be run locally.
a discussion (no related file):
I think tools/ci/create_ecr_repos
can also be removed. Afaict no more docker images are pushed to ECR? Where is tools/ci/get_metrics
used?
.buildkite/steps/common.sh, line 27 at r1 (raw file):
softnet_stat_snapshot() { # Collect packet loss info pre test execution cat /proc/net/softnet_stat > /tmp/snapshot_softnet_stat
do we have something like this in the new pipeline?
.buildkite/steps/common.sh, line 31 at r1 (raw file):
detect_packet_loss_since_snapshot() { # Compare column2 of softnet_stat to detect kernel packet loss and print snapshot and current in case of packet loss
same as above?
0871c06
to
ed23e67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 27 of 29 files reviewed, 4 unresolved discussions (waiting on @worxli)
a discussion (no related file):
Previously, worxli (Lukas Bischofberger) wrote…
This PR misses a description how the new pipeline can be run locally.
Done.
a discussion (no related file):
Previously, worxli (Lukas Bischofberger) wrote…
I think
tools/ci/create_ecr_repos
can also be removed. Afaict no more docker images are pushed to ECR? Where istools/ci/get_metrics
used?
Done. Removed
.buildkite/steps/common.sh, line 27 at r1 (raw file):
Previously, worxli (Lukas Bischofberger) wrote…
do we have something like this in the new pipeline?
Created #3585
.buildkite/steps/common.sh, line 31 at r1 (raw file):
Previously, worxli (Lukas Bischofberger) wrote…
same as above?
Created #3585
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
a discussion (no related file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
Done.
Should be somewhere in a README or similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @worxli)
a discussion (no related file):
Previously, worxli (Lukas Bischofberger) wrote…
Should be somewhere in a README or similar?
Well when it works sure. For now it doesn't work fully. #3286
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
ed23e67
to
c66deff
Compare
Running the new pipeline locally is not yet fully supported. The steps required currently are:
.builkite/pipeline2.sh > full-pipeline.yml
bk local run --env LOGNAME=$USER full-pipeline.yml
More information about local running: ci: running buildkite builds locally #3286
Fixes #3574
Fixes #3568
This change is