Skip to content

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Jan 7, 2020

Running the new pipeline locally is not yet fully supported. The steps required currently are:

Fixes #3574
Fixes #3568


This change is Reviewable

@lukedirtwalker lukedirtwalker requested a review from worxli January 7, 2020 07:28
Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 27 of 27 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @lukedirtwalker)

a discussion (no related file):
This PR misses a description how the new pipeline can be run locally.


a discussion (no related file):
I think tools/ci/create_ecr_repos can also be removed. Afaict no more docker images are pushed to ECR? Where is tools/ci/get_metrics used?



.buildkite/steps/common.sh, line 27 at r1 (raw file):

softnet_stat_snapshot() {
    # Collect packet loss info pre test execution
    cat /proc/net/softnet_stat > /tmp/snapshot_softnet_stat

do we have something like this in the new pipeline?


.buildkite/steps/common.sh, line 31 at r1 (raw file):

detect_packet_loss_since_snapshot() {
    # Compare column2 of softnet_stat to detect kernel packet loss and print snapshot and current in case of packet loss

same as above?

Copy link
Collaborator Author

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 27 of 29 files reviewed, 4 unresolved discussions (waiting on @worxli)

a discussion (no related file):

Previously, worxli (Lukas Bischofberger) wrote…

This PR misses a description how the new pipeline can be run locally.

Done.


a discussion (no related file):

Previously, worxli (Lukas Bischofberger) wrote…

I think tools/ci/create_ecr_repos can also be removed. Afaict no more docker images are pushed to ECR? Where is tools/ci/get_metrics used?

Done. Removed



.buildkite/steps/common.sh, line 27 at r1 (raw file):

Previously, worxli (Lukas Bischofberger) wrote…

do we have something like this in the new pipeline?

Created #3585


.buildkite/steps/common.sh, line 31 at r1 (raw file):

Previously, worxli (Lukas Bischofberger) wrote…

same as above?

Created #3585

Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)

a discussion (no related file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Done.

Should be somewhere in a README or similar?


Copy link
Collaborator Author

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @worxli)

a discussion (no related file):

Previously, worxli (Lukas Bischofberger) wrote…

Should be somewhere in a README or similar?

Well when it works sure. For now it doesn't work fully. #3286


Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit 9111ad9 into scionproto:master Jan 9, 2020
@lukedirtwalker lukedirtwalker deleted the pubCICleanup2 branch January 9, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up buildkite pipelines Remove legacy CI pipeline code
2 participants