Skip to content

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Jan 6, 2020

Contributes #2926


This change is Reviewable

@lukedirtwalker lukedirtwalker requested a review from oncilla January 6, 2020 14:15
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)


go/beacon_srv/internal/ifstate/ifstate.go, line 160 at r1 (raw file):

// and propagation are reset to the zero value. The return value indicates,
// whether the state is expired or revoked when the call returns.
func (intf *Interface) Expire() bool {

The doc string needs to be updated.
Probably, the method should now be called Revoked or similar.


go/beacon_srv/internal/ifstate/ifstate.go, line 179 at r1 (raw file):

// interface has been activated in the meantime and should not be revoked.
// This is indicated through an error.
func (intf *Interface) Revoke(rev *path_mgmt.SignedRevInfo) error {

Update doc string.
Should probably be called SetRevocation or similar

Copy link
Collaborator Author

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @oncilla)


go/beacon_srv/internal/ifstate/ifstate.go, line 160 at r1 (raw file):

Previously, Oncilla wrote…

The doc string needs to be updated.
Probably, the method should now be called Revoked or similar.

Done.


go/beacon_srv/internal/ifstate/ifstate.go, line 179 at r1 (raw file):

Previously, Oncilla wrote…

Update doc string.
Should probably be called SetRevocation or similar

Done.

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


doc/BeaconService.md, line 139 at r2 (raw file):

The BS periodically evicts beacons that contain revoked interfaces.

### Interfaces State

💯 for remembering to update

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit 918622b into scionproto:master Jan 8, 2020
@lukedirtwalker lukedirtwalker deleted the pubBSReduceIFState branch January 8, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants