Skip to content

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Jan 6, 2020

Add python unit tests to new CI pipeline

fixes #3569


This change is Reviewable

@oncilla oncilla requested a review from lukedirtwalker January 6, 2020 15:06
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @oncilla)


.buildkite/pipeline_buildlint.yml, line 22 at r1 (raw file):

:py:

:python:


.buildkite/pipeline_buildlint.yml, line 28 at r1 (raw file):

      automatic:
        - exit_status: -1  # Agent was lost
        - exit_status: 255 # Forced agent shutdown

the tests don't write to logs right?

Copy link
Contributor Author

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)


.buildkite/pipeline_buildlint.yml, line 22 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…
:py:

:python:

Done.


.buildkite/pipeline_buildlint.yml, line 28 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

the tests don't write to logs right?

not any useful ones, afaict

Add python unit tests to new CI pipeline

fixes scionproto#3569
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla oncilla merged commit b22896f into scionproto:master Jan 6, 2020
@oncilla oncilla deleted the pub-add-py-unit branch January 6, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python unit tests to v2 pipeline
2 participants