snet: Add context to Dispatcher and Listen and Dial #3562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukedirtwalker
commented
Dec 30, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 21 files reviewed, 1 unresolved discussion (waiting on @scrye)
go/beacon_srv/main.go, line 216 at r1 (raw file):
ctx, cancelF := context.WithTimeout(context.Background(), time.Second) defer cancelF() conn, _, err := pktDisp.Register(ctx, topo.IA(), ohpAddress, addr.SvcNone)
this should use context.Background()
scrye
approved these changes
Dec 30, 2019
There was a problem hiding this comment.
Reviewed 18 of 21 files at r1, 3 of 3 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
831d30f to
ab77e50
Compare
scrye
approved these changes
Dec 30, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes #3136
This change is