Make scmp.Error compatible with go 1.13 error funcs #3558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove ToError, instead use errors.As Add Unwrap method Also remove Convey from spkt test. Fixes scionproto#3312
015c98d to
c0ae3bf
Compare
scrye
suggested changes
Dec 30, 2019
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
go/lib/spkt/cmnhdr.go, line 44 at r1 (raw file):
// ErrUnsupportedVersion indicates an unsupported SCION version. var ErrUnsupportedVersion = serrors.New("unsuppoerted SCION version")
typo: unsuppoerted
lukedirtwalker
commented
Dec 30, 2019
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scrye)
go/lib/spkt/cmnhdr.go, line 44 at r1 (raw file):
Previously, scrye (Sergiu Costea) wrote…
typo: unsuppoerted
Done.
scrye
approved these changes
Dec 30, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ToError, instead use errors.As
Add Unwrap method
Also remove Convey from spkt test.
Fixes #3312
This change is