Skip to content

Conversation

scrye
Copy link
Contributor

@scrye scrye commented Dec 18, 2019

The proxy can be used to replace border routers in some acceptance
tests.


This change is Reviewable

@scrye scrye added the feature New feature or request label Dec 18, 2019
@scrye scrye requested a review from lukedirtwalker December 18, 2019 08:52
@scrye scrye self-assigned this Dec 18, 2019
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scrye)


go/tools/udpproxy/udpproxy.go, line 64 at r1 (raw file):

		}
	}

Nit: not needed

The proxy can be used to replace border routers in some acceptance
tests.
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scrye scrye merged commit a943ca1 into scionproto:master Dec 18, 2019
@scrye scrye deleted the pubpr-add-udp-proxy branch December 18, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants