Skip to content

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Dec 16, 2019

Export all private types and let the app instantiate the components
as it sees fit.


This change is Reviewable

@oncilla oncilla added the c/CPPKI SCION Control-plane PKI label Dec 16, 2019
@oncilla oncilla added this to the Q4S5.D milestone Dec 16, 2019
@oncilla oncilla requested a review from scrye December 16, 2019 14:50
@oncilla oncilla force-pushed the pub-trust-the-great-export branch from 0098287 to c67ca2e Compare December 17, 2019 08:03
@oncilla oncilla requested review from lukedirtwalker and removed request for scrye December 17, 2019 09:21
Export all private types and let the app instantiate the components
as it sees fit.
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @oncilla)


go/lib/infra/modules/trust/v2/provider.go, line 312 at r1 (raw file):

}

//GetASKey returns from trust store the public key required to verify signature

Space after //


go/lib/infra/modules/trust/v2/resolver.go, line 109 at r1 (raw file):

*

Should we also use value receiver here?


go/lib/infra/modules/trust/v2/resolver.go, line 225 at r1 (raw file):

// missing in the DB, network requests are allowed.
type resolveWrap struct {
	resolver *DefaultResolver

value?


go/lib/infra/modules/trust/v2/router.go, line 54 at r1 (raw file):

// ASes of the appropriate ISD.
//
// TODO(roosd): Add implementation of snet.Router that routs to authoritative AS.

Nit: s/routs/routes/

@oncilla oncilla force-pushed the pub-trust-the-great-export branch from c67ca2e to 23cc22f Compare December 17, 2019 09:30
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @oncilla)

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor Author

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


go/lib/infra/modules/trust/v2/provider.go, line 312 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Space after //

Done.


go/lib/infra/modules/trust/v2/resolver.go, line 109 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…
*

Should we also use value receiver here?

Done.


go/lib/infra/modules/trust/v2/resolver.go, line 225 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

value?

Done.


go/lib/infra/modules/trust/v2/router.go, line 54 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Nit: s/routs/routes/

Done.

@oncilla oncilla merged commit 5920153 into scionproto:master Dec 17, 2019
@oncilla oncilla deleted the pub-trust-the-great-export branch December 17, 2019 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/CPPKI SCION Control-plane PKI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants