-
Notifications
You must be signed in to change notification settings - Fork 173
TrustStore: The great export #3530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TrustStore: The great export #3530
Conversation
0098287
to
c67ca2e
Compare
Export all private types and let the app instantiate the components as it sees fit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 13 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @oncilla)
go/lib/infra/modules/trust/v2/provider.go, line 312 at r1 (raw file):
} //GetASKey returns from trust store the public key required to verify signature
Space after //
go/lib/infra/modules/trust/v2/resolver.go, line 109 at r1 (raw file):
*
Should we also use value receiver here?
go/lib/infra/modules/trust/v2/resolver.go, line 225 at r1 (raw file):
// missing in the DB, network requests are allowed. type resolveWrap struct { resolver *DefaultResolver
value?
go/lib/infra/modules/trust/v2/router.go, line 54 at r1 (raw file):
// ASes of the appropriate ISD. // // TODO(roosd): Add implementation of snet.Router that routs to authoritative AS.
Nit: s/routs/routes/
c67ca2e
to
23cc22f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @oncilla)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
go/lib/infra/modules/trust/v2/provider.go, line 312 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
Space after
//
Done.
go/lib/infra/modules/trust/v2/resolver.go, line 109 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
*
Should we also use value receiver here?
Done.
go/lib/infra/modules/trust/v2/resolver.go, line 225 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
value?
Done.
go/lib/infra/modules/trust/v2/router.go, line 54 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
Nit:
s/routs/routes/
Done.
Export all private types and let the app instantiate the components
as it sees fit.
This change is