Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)

a discussion (no related file):
I don't see how this approach with the generator can be a good solution. There is nothing to enforce consistency.

Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @worxli)

a discussion (no related file):

Done.

Reviewed 3 of 7 files at r1, 1 of 3 files at r2.
Reviewable status: 4 of 8 files reviewed, 5 unresolved discussions (waiting on @lukedirtwalker and @worxli)

.buildkite/hooks/post-artifact, line 5 at r2 (raw file):

set -eo pipefail

rm -rf "bazel-testlogs" "logs" "traces" "gen" "gen-cache"

why the quotes?

.buildkite/hooks/pre-exit, line 3 at r2 (raw file):

#!/bin/bash

./scion.sh topo_clean

I don't think this adds any value here.

.buildkite/hooks/pre-exit, line 13 at r2 (raw file):

docker volume prune -f

rm -rf bazel-testlogs logs traces gen gen-cache accept_artifacts

already done in post artifact for most?

.buildkite/pipeline2.sh, line 11 at r2 (raw file):

        echo "  - label: \"Acceptance: $name\""
        echo "    command:"
        echo "      - \"rm -rf \$\$ACCEPTANCE_ARTIFACTS\""

when is this necessary?

Reviewable status: 3 of 7 files reviewed, 5 unresolved discussions (waiting on @lukedirtwalker and @worxli)

.buildkite/hooks/post-artifact, line 5 at r2 (raw file):

Done.

.buildkite/hooks/pre-exit, line 3 at r2 (raw file):

for non-dockerized tests this makes sure that all binaries are gone. Now that prost-artifact doesn't delete the gen folder it should actually work ;)

.buildkite/hooks/pre-exit, line 13 at r2 (raw file):

removed post-artifact

Reviewable status: 3 of 7 files reviewed, 5 unresolved discussions (waiting on @worxli)

.buildkite/pipeline2.sh, line 11 at r2 (raw file):

Hopefully never, removed

Reviewed 2 of 7 files at r1, 1 of 3 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 1 of 1 files at r5.
Reviewable status: complete! all files reviewed, all discussions resolved

Reviewed 1 of 1 files at r6.
Reviewable status: complete! all files reviewed, all discussions resolved