Skip to content

Consistently handle nil in Copy implementations #3534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2019
Merged

Consistently handle nil in Copy implementations #3534

merged 2 commits into from
Dec 17, 2019

Conversation

matzf
Copy link
Contributor

@matzf matzf commented Dec 17, 2019 •
edited by kormat
Loading

Check for nil-receiver in Copy.

The trigger for this change is a recently introduced small bug in snet.Dial where copying a nil-Path causes a panic.

This change is Reviewable

@matzf matzf changed the title Fix copy nil Consistently handle nil in Copy implementations Dec 17, 2019
lukedirtwalker
lukedirtwalker approved these changes Dec 17, 2019
View reviewed changes
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 23 of 23 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit 99bf56e into scionproto:master Dec 17, 2019
@matzf matzf deleted the fix-copy-nil branch December 17, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukedirtwalker lukedirtwalker lukedirtwalker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matzf @lukedirtwalker