Skip to content

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Dec 16, 2019

Co-Authored-By: @worxli


This change is Reviewable

Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker and @worxli)


.buildkite/pipeline.yml, line 26 at r2 (raw file):

      - "mkdir /tmp/$BUILDKITE_STEP_ID/"
      - "cp go.mod go.sum go_deps.bzl /tmp/$BUILDKITE_STEP_ID/"
      - "make godeps -B;"

remove :

Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)


.buildkite/pipeline.yml, line 26 at r2 (raw file):

Previously, worxli (Lukas Bischofberger) wrote…

remove :

;

Copy link
Collaborator Author

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @worxli)


.buildkite/pipeline.yml, line 26 at r2 (raw file):

Previously, worxli (Lukas Bischofberger) wrote…

;

Done.

Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit 772d6b5 into scionproto:master Dec 16, 2019
@lukedirtwalker lukedirtwalker deleted the pubCI2Lint branch December 16, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants