-
Notifications
You must be signed in to change notification settings - Fork 173
CI: Add lint steps to new pipeline #3520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
897b533
to
878a6ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
878a6ab
to
eb56f31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker and @worxli)
.buildkite/pipeline.yml, line 26 at r2 (raw file):
- "mkdir /tmp/$BUILDKITE_STEP_ID/" - "cp go.mod go.sum go_deps.bzl /tmp/$BUILDKITE_STEP_ID/" - "make godeps -B;"
remove :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
.buildkite/pipeline.yml, line 26 at r2 (raw file):
Previously, worxli (Lukas Bischofberger) wrote…
remove
:
;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @worxli)
.buildkite/pipeline.yml, line 26 at r2 (raw file):
Previously, worxli (Lukas Bischofberger) wrote…
;
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
Co-Authored-By: @worxli
This change is