Skip to content

Conversation

karampok
Copy link
Contributor

@karampok karampok commented Dec 13, 2019

This change is Reviewable

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @karampok and @oncilla)


go/lib/infra/modules/trust/v2/verifier_test.go, line 14 at r1 (raw file):

// See the License for the specific language governing permissions and
// limitations under the License.
//

remove last line

@karampok karampok changed the title Add missing lisence header Add missing license header Dec 13, 2019
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@karampok karampok merged commit b3339eb into scionproto:master Dec 16, 2019
@karampok karampok deleted the add-license branch January 29, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants