TrustStore: Add signer #3516
TrustStore: Add signer #3516
Conversation
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @oncilla)
go/lib/infra/modules/trust/v2/signer_test.go, line 142 at r1 (raw file):
input := sign.SigInput([]byte("wasn't me"), false) scrypto.Verify(input, sign.Signature, pub, scrypto.Ed25519)
require.NoError(t, scrypto.Verify(...))
go/lib/infra/modules/trust/v2/signer_test.go, line 345 at r1 (raw file):
meta := loadChain(t, chain110v1).AS.Keys[cert.SigningKey] input := sign.SigInput([]byte("wasn't me"), false) scrypto.Verify(input, sign.Signature, meta.Key, meta.Algorithm)
require.NoError
Add Signer that implements infra.Signer. Additionally, add a signer generator that selects the correct key based on the latest certificate chain. fixes scionproto#3118
375b31c to
542a0f1
Compare
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)
go/lib/infra/modules/trust/v2/signer_test.go, line 142 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
require.NoError(t, scrypto.Verify(...))
Done.
go/lib/infra/modules/trust/v2/signer_test.go, line 345 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
require.NoError
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Add Signer that implements infra.Signer.
Additionally, add a signer generator that selects the correct key based
on the latest certificate chain.
fixes #3118
This change is