TrustDB: Implement GetIssuingKeyInfo #3503
Conversation
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
go/lib/infra/modules/trust/v2/trustdbtest/trustdbtest.go, line 236 at r1 (raw file):
xtest.AssertErrorsIs(t, err, trust.ErrNotFound) assert.Equal(t, trust.KeyInfo{}, actual) })
add test for non-existent AS in existing TRC and test for non-issuing existing AS
308f833 to
c0bf5a3
Compare
There was a problem hiding this comment.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @oncilla)
go/lib/infra/modules/trust/v2/trustdbtest/trustdbtest.go, line 236 at r1 (raw file):
Previously, Oncilla wrote…
add test for non-existent AS in existing TRC and test for non-issuing existing AS
non-existent AS in existing TRC is already done in fetch non-existant ia
added one for non-issuing. (thanks for the TRC)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
We chose to not add a new table for this. If this ever becomes a performance bottleneck we can still add a table. Fixes 3113
c0bf5a3 to
84c7e01
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3.
Reviewable status:
We chose to not add a new table for this.
If this ever becomes a performance bottleneck we can still add a table.
Fixes #3113
This change is