Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @oncilla)

go/lib/infra/modules/trust/v2/handlers.go, line 28 at r1 (raw file):

// HandlerTimeout is the lifetime of the handlers.
const HandlerTimeout = 3 * time.Second

Do we specifically care about the 3 seconds? isn't the default provided by the messenger "good enough" ?

go/lib/infra/modules/trust/v2/handlers.go, line 32 at r1 (raw file):

// trcReqHandler contains the state of a handler for a specific TRC Request
// message, received via the Messenger's ListenAndServe method.
type trcReqHandler struct {

I that is not public how can it be registered in the messenger in a main then?

go/lib/infra/modules/trust/v2/handlers.go, line 53 at r1 (raw file):

no Messenger found"

no ResponseWriter found

go/lib/infra/modules/trust/v2/handlers.go, line 53 at r1 (raw file):

logger.Warn

Make this an Error log

go/lib/infra/modules/trust/v2/handlers.go, line 56 at r1 (raw file):

		return infra.MetricsErrInternal
	}
	subCtx, cancelF := context.WithTimeout(h.request.Context(), HandlerTimeout)

I think it's good enough to just use the provided context.
At the top I would put:

ctx := request.Context()
logger := log.FromCtx(ctx)

go/lib/infra/modules/trust/v2/handlers.go, line 67 at r1 (raw file):

		opts, h.request.Peer)
	if err != nil {
		logger.Error("[TrustStore:trcReqHandler] Unable to retrieve TRC", "err", err)

Shouldn't we reply with Nack in this case?

Reviewable status: 1 of 4 files reviewed, 6 unresolved discussions (waiting on @lukedirtwalker)

go/lib/infra/modules/trust/v2/handlers.go, line 28 at r1 (raw file):

copy-pasta from the old TS
Done.

go/lib/infra/modules/trust/v2/handlers.go, line 32 at r1 (raw file):

The trust store struct will have some factory methods that create the handlers.

As you will notice, this is not of type infra.Handler

go/lib/infra/modules/trust/v2/handlers.go, line 53 at r1 (raw file):

Done.

go/lib/infra/modules/trust/v2/handlers.go, line 53 at r1 (raw file):

Done.

go/lib/infra/modules/trust/v2/handlers.go, line 56 at r1 (raw file):

Done.

go/lib/infra/modules/trust/v2/handlers.go, line 67 at r1 (raw file):

Done.

Reviewed 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

Reviewed 3 of 3 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved