Skip to content

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Dec 9, 2019

Add TRC push handler to the trust store.
Currently, the PR is missing unit tests. Edit by @scrye: added unit tests

fixes #3483


This change is Reviewable

@scrye scrye self-assigned this Dec 10, 2019
oncilla and others added 2 commits December 10, 2019 15:39
Add TRC push handler to the trust store.
Currently, the PR is missing unit tests.

fixes scionproto#3483
@scrye scrye force-pushed the pub-trust-handler-trc-push branch from 1a7d317 to 4f3e4e8 Compare December 10, 2019 14:55
Copy link
Contributor Author

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @scrye)

a discussion (no related file):
Just make sure to edit the commit message when merging



go/lib/infra/modules/trust/v2/handlers.go, line 109 at r2 (raw file):

	}
	logger := log.FromCtx(h.request.Context())
	if h.request.Message == nil {

Wait, how does the message being nil matter?
That was fixed in a previous PR.


go/lib/infra/modules/trust/v2/handlers.go, line 113 at r2 (raw file):

		return infra.MetricsErrInternal
	}
	// XXX(scrye): In case a TRC update will invalidate the local certificate

Do we actually have an issue to track this?
We should add this to next sprint.

Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @oncilla and @scrye)

a discussion (no related file):

Previously, Oncilla wrote…

Just make sure to edit the commit message when merging

Will do 👍



go/lib/infra/modules/trust/v2/handlers.go, line 109 at r2 (raw file):

Previously, Oncilla wrote…

Wait, how does the message being nil matter?
That was fixed in a previous PR.

Done.


go/lib/infra/modules/trust/v2/handlers.go, line 113 at r2 (raw file):

Previously, Oncilla wrote…

Do we actually have an issue to track this?
We should add this to next sprint.

Added https://github.com/Anapaya/scion/issues/1685.

Copy link
Contributor Author

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @scrye)

Copy link
Contributor Author

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scrye)

Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scrye scrye merged commit 5b8d396 into scionproto:master Dec 10, 2019
@oncilla oncilla deleted the pub-trust-handler-trc-push branch December 11, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TrustStore: TRC push handler
2 participants