Skip to content

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Nov 13, 2019

This change adds the ability to prototype, sign and combine a TRC
with a single command. The only the final signed TRC is stored on the
file system.

This PR also re-enables the trust store unit tests.
fixes #3317


This change is Reviewable

@oncilla oncilla added c/tooling SCION network tools c/CPPKI SCION Control-plane PKI labels Nov 13, 2019
@oncilla oncilla added this to the Q4S3.D milestone Nov 13, 2019
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 13 of 13 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

This change adds the ability to prototype, sign and combine a TRC
with a single command. The only the final signed TRC is stored on the
file system.
@oncilla oncilla merged commit 65dacc6 into scionproto:master Nov 14, 2019
@oncilla oncilla deleted the pub-spki-gen-all branch November 14, 2019 07:58
@oncilla oncilla mentioned this pull request Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/CPPKI SCION Control-plane PKI c/tooling SCION network tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TrustStore: Enable unit tests
2 participants