Skip to content

Acceptance tests: Move reload_sig function to a library #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2019
Merged

Acceptance tests: Move reload_sig function to a library #3361

merged 1 commit into from
Nov 12, 2019

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Nov 12, 2019 •
edited by kormat
Loading

This change is Reviewable

@sustrik sustrik requested review from sgmonroy and lukedirtwalker and removed request for sgmonroy November 12, 2019 09:36
lukedirtwalker
lukedirtwalker approved these changes Nov 12, 2019
View reviewed changes
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sustrik sustrik merged commit 62f2bb5 into scionproto:master Nov 12, 2019
@sustrik sustrik deleted the sig-reload branch November 14, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukedirtwalker lukedirtwalker lukedirtwalker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sustrik @lukedirtwalker