Skip to content

SIG: move base to internal #3369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2019
Merged

SIG: move base to internal #3369

merged 1 commit into from
Nov 13, 2019

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Nov 13, 2019 •
edited by kormat
Loading

This change is Reviewable

@sustrik sustrik requested a review from karampok November 13, 2019 09:12
karampok
karampok approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@karampok karampok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sustrik sustrik merged commit 0def399 into scionproto:master Nov 13, 2019
@sustrik sustrik deleted the move-base branch November 14, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@karampok karampok karampok approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sustrik @karampok