seghandler: Report error if all segments fail to verify #3368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oncilla
requested changes
Nov 13, 2019
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
go/lib/infra/modules/seghandler/seghandler.go, line 116 at r1 (raw file):
result.verifyErrs = append(allVerifyErrs, verifyErrs...) result.stats.verificationErrs(result.verifyErrs) if err == nil && result.stats.SegVerifyErrors() == units {
is equivalent to:
if err != nil {
result.err = serrors.Wrap(ErrDB, err)
} else if result.stats.SegVerifyErrors() == units {
result.err = serrors.Wrap(ErrVerification, result.verifyErrs.ToError())
}
or
switch {
case err != nil:
result.err = serrors.Wrap(ErrDB, err)
case result.stats.SegVerifyErrors() == units:
result.err = serrors.Wrap(ErrVerification, result.verifyErrs.ToError())
}
oncilla
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
7f5d5f3 to
c9f661d
Compare
Also log verification error in all seghandler using code. Also clean up error and make sure metrics report this correctly. Fixes scionproto#3357 Fixes scionproto#3351
c9f661d to
5ae1cef
Compare
oncilla
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
oncilla
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also log verification error in all seghandler using code.
Also clean up error and make sure metrics report this correctly.
Fixes #3357
Fixes #3351
This change is