snet: remove goconvey #3350
Merged
snet: remove goconvey #3350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oncilla
requested changes
Nov 11, 2019
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @karampok)
go/lib/snet/addr_test.go, line 44 at r1 (raw file):
{address: &Addr{IA: ia, Host: host6}, result: "1-ff00:0:320,[2001::1]:20000"}, } t.Run("Method String", func(t *testing.T) {
drop
go/lib/snet/addr_test.go, line 108 at r1 (raw file):
}, } t.Run("Function AddrFromString", func(t *testing.T) {
drop
Contributes scionproto#3016
7691cc8 to
bff7c57
Compare
karampok
commented
Nov 11, 2019
There was a problem hiding this comment.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @oncilla)
go/lib/snet/addr_test.go, line 44 at r1 (raw file):
Previously, Oncilla wrote…
drop
Done.
go/lib/snet/addr_test.go, line 108 at r1 (raw file):
Previously, Oncilla wrote…
drop
Done.
oncilla
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes #3016
This change is