Skip to content

metric: do not init label values to an empty string #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2019
Merged

metric: do not init label values to an empty string #3333

merged 1 commit into from
Nov 7, 2019

Conversation

karampok
Copy link
Contributor

@karampok karampok commented Nov 7, 2019 •
edited by kormat
Loading

Fixes #3298

This change is Reviewable

@karampok karampok requested a review from worxli November 7, 2019 10:40
@karampok karampok self-assigned this Nov 7, 2019
@karampok karampok changed the title metric: init label values to an empty string metric: do not init label values to an empty string Nov 7, 2019
lukedirtwalker
lukedirtwalker approved these changes Nov 7, 2019
View reviewed changes
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @worxli)

@karampok karampok merged commit 3b3e16f into scionproto:master Nov 7, 2019
@karampok karampok deleted the pub-label-init branch November 7, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukedirtwalker lukedirtwalker lukedirtwalker approved these changes

@worxli worxli Awaiting requested review from worxli

Assignees

@karampok karampok

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not Initialize all metric with labels
2 participants
@karampok @lukedirtwalker