Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)

go/tools/scion-pki/internal/v2/keys/priv.go, line 224 at r1 (raw file):

		return private, err
	default:
		return nil, serrors.New("unsupported key algorithm", "algo", algo)

if you do a GoCoverage the errors case are not unit-tested.
(but its okay, just for stats)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @karampok)

go/tools/scion-pki/internal/v2/keys/priv.go, line 224 at r1 (raw file):

Yes, the error cases are not tested.
I'm not convinced it is worth introducing the tests.

Reviewable status: complete! all files reviewed, all discussions resolved

go/tools/scion-pki/internal/v2/keys/priv.go, line 224 at r1 (raw file):

fine by me (i was not blocking you on that, right?)