Skip to content

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Nov 6, 2019

Also introduce xtest.AssertErrorsIs and use it instead of manual asserts with xerrors.Is

Contributes #3016


This change is Reviewable

@lukedirtwalker lukedirtwalker added the refactor Change that focuses around reducing tech debt label Nov 6, 2019
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 48 of 48 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)


go/lib/l4/udp_test.go, line 33 at r1 (raw file):

func TestUDPFromRaw(t *testing.T) {
	t.Run("Content must match", func(t *testing.T) {

drop all t.Run here


go/lib/scrypto/asym_test.go, line 63 at r1 (raw file):

func TestGenKeyPairs(t *testing.T) {
	t.Run("GenKeyPairs should return a valid Curve25519xSalsa20Poly1305 key pair",

Table driven test would be nice here.

But I understand it is a bit tedious, so feel free to add or not.

Copy link
Collaborator Author

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 47 of 48 files reviewed, 1 unresolved discussion (waiting on @oncilla)


go/lib/l4/udp_test.go, line 33 at r1 (raw file):

Previously, Oncilla wrote…

drop all t.Run here

Done.


go/lib/scrypto/asym_test.go, line 63 at r1 (raw file):

Previously, Oncilla wrote…

Table driven test would be nice here.

But I understand it is a bit tedious, so feel free to add or not.

Not this time, I tried to it for Decrypt, but it was more lines so I aborted the mission.

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit 2ceca10 into scionproto:master Nov 7, 2019
@lukedirtwalker lukedirtwalker deleted the pubRemoveConvey branch November 7, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Change that focuses around reducing tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants