Skip to content

Conversation

worxli
Copy link
Contributor

@worxli worxli commented Nov 8, 2019

Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @worxli)


.bazelrc, line 1 at r1 (raw file):

build --workspace_status_command=./tools/bazel-build-env --disk_cache=.bazel-cache

Let's go with ./.bazel-cache for consistency.

Copy link
Contributor Author

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @kormat)


.bazelrc, line 1 at r1 (raw file):

Previously, kormat (Stephen Shirley) wrote…

Let's go with ./.bazel-cache for consistency.

Done.

Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@worxli worxli merged commit 1cb9d08 into scionproto:master Nov 8, 2019
@worxli worxli deleted the bazel-cache branch November 8, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants