Skip to content

periodic: increase period and error verbosity #3335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2019
Merged

periodic: increase period and error verbosity #3335

merged 1 commit into from
Nov 7, 2019

Conversation

karampok
Copy link
Contributor

@karampok karampok commented Nov 7, 2019 •
edited by kormat
Loading

This change is Reviewable

@karampok
Copy link
Contributor Author

karampok commented Nov 7, 2019

The errors

ing tests from //go/lib/periodic:go_default_test
-----------------------------------------------------------------------------
--- FAIL: TestPeriodicExecution (1.01s)
    periodic_test.go:66: time out while waiting on first run
    periodic_test.go:50:
                Error Trace:    periodic_test.go:50
                                                        periodic_test.go:73
                Error:          Received unexpected error:
                                timed out after 1s
                Test:           TestPeriodicExecution

exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //go/lib/periodic:go_default_test
-----------------------------------------------------------------------------
--- FAIL: TestPeriodicExecution (0.03s)
    periodic_test.go:66: time out while waiting on first run
FAIL

@karampok karampok requested review from oncilla and removed request for lukedirtwalker November 7, 2019 14:59
@karampok karampok self-assigned this Nov 7, 2019
oncilla
oncilla approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@karampok karampok force-pushed the pub-fix-periodic-two branch from 2c58e6e to 479e46d Compare November 7, 2019 15:26
@karampok
Copy link
Contributor Author

karampok commented Nov 7, 2019 

--- FAIL: TestTriggerNow (0.02s)
    periodic_test.go:144: time out while waiting on first run
    periodic_test.go:152:
                Error Trace:    periodic_test.go:152
                Error:          "%!s(int=0)" is not greater or equal than "%!s(int=9)"
                Test:           TestTriggerNow
                Messages:       Must run 9 times within short time

@karampok karampok force-pushed the pub-fix-periodic-two branch from 479e46d to 351c9cb Compare November 7, 2019 15:44
oncilla
oncilla approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @karampok)

oncilla
oncilla approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @karampok)

@karampok karampok merged commit ddc94d3 into scionproto:master Nov 7, 2019
@karampok karampok deleted the pub-fix-periodic-two branch December 3, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oncilla oncilla oncilla approved these changes

Assignees

@karampok karampok

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karampok @oncilla