Remove addr.L4Info #3323
Remove addr.L4Info #3323
Conversation
There was a problem hiding this comment.
Reviewed 53 of 58 files at r1.
Reviewable status: 53 of 58 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker, @scrye, and @sgmonroy)
go/lib/infra/messenger/addr.go, line 126 at r1 (raw file):
// SVC addresses in the local AS get resolved via topology lookup if svc, ok := newAddr.Host.L3.(addr.HostSVC); ok && r.Router.LocalIA() == newAddr.IA {
why this extra line?
There was a problem hiding this comment.
Reviewed 5 of 58 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scrye and @sgmonroy)
There was a problem hiding this comment.
Reviewed 9 of 58 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scrye)
The addr.L4Info interface type was always used as a normal 2-byte port. However, code needed to account for the possibility of other implementations. By using uint16 directly the code gets much simpler. Fixes #3296.
There was a problem hiding this comment.
Reviewable status: 49 of 58 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker and @sgmonroy)
go/lib/infra/messenger/addr.go, line 126 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
why this extra line?
Done.
There was a problem hiding this comment.
Reviewed 9 of 9 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
The addr.L4Info interface type was always used as a normal 2-byte port.
However, code needed to account for the possibility of other
implementations. By using uint16 directly the code gets much simpler.
Fixes #3296.
This change is